Lupoex

istrau2

https://lupoex.com is a decentralized trading client built on top of the stellar network.

Users can:

1) Search through all stellar assets/issuers
2) Manage their accounts
3) Create offers
4) View OLHCV data
5) View orderbook data
6) Send payments

You can test the website on the stellar test network at http://test.lupoex.com

We have a lot more planned. Please use this discussion to let us know your thoughts, ideas and possible bugs.

In terms of updates since the last SBC:
The entire site has been upgraded. Its hard to list all the updates specifically. However, generally speaking, lupoex is now a fully functional trading client with many advanced features (whereas it was just a simple visualizer at the last build challenge).

Thanks, looking forward to your comments.

sacarlson

Wow this has got to be the most amazing stellar.org network trading platform I have EVER seen. This site goes way outside of what anyone has yet to touch in trading on stellar.org network. The most visible feature that I note is they have trade history graphs WITH volume!! I had not yet seen anyone else do that on stellar until now with lupoex.

But it doesn't even stop there! it not only can trade but also can act as a standard wallet to send payments, view asset balances, view trade history with date and much more.

I plan to continue to do more tests with this web app but so far it is totally cool. I think if I was the judge of this contest I would be giving this first prize for sure!

One question I have is if this is open source? If it was I'm sure there would be many that would learn a lot from what was done here.

And about only one added advanced feature I might want them to consider at some point would be to support multi-sig accounts to allow not requiring to even fully trust lupoex.com with the full set of signer keys. Allow the final transaction to be optionally also signed at some remote wallet like stellar labs or my_wallet or stargazer or any other at some point. With a feature like this even big traders wouldn't need to worry about this sites security.

OK That's it from me,

Good Luck in the contest!!

istrau2

sacarlson Thanks for the review. Much appreciated.

In response to your questions:
1) It is not open source now, perhaps at some point.
2) Delegation of signing is a planned feature. Look for it in the coming months.

lumag

The price history graph seems to be lagging by about 21 hours for me after just now viewing it. This is the chart I am now looking at using Range 4 days and Interval 1h: https://lupoex.com/exchange/CNY/GAREELUB43IRHWEASCFBLKHURCGMHE5IF6XSE7EXDLACYHGRHM43RFOX/XLM/native

The asset search selection part seems really nice.

istrau2

lumag

Thanks for the feedback. I can't seem to reproduce your issue. Maybe your issue is being caused by one of the following:

1) There may not be an axis tick at each data point, still you need to hover over the last data point to see the last time that is charted.
2) The times are displayed in your time zone.
3) There is a selection brush at the bottom of the chart. Ensure that you have selected it all the way to the right (to view the latest data).

lumag

It seems fine now after freshly reloading the page. The 21 hour lag seemed to occur after I adjusted the zoom slider/selection brush on the bottom and then tried to move the slider all the way back to the right to return to view the current price and it wouldn't for me. That seems to still be reproducible, if I'm able to explain it well enough. It is only a minor thing though.

sacarlson

I noted something that I thought was a lupoex bug but may be partly a bug/feature of stellar that the default value of buy or sell may not trigger an order. It seems if the value of bid and ask order are setup that are exactly the same that it won't trade the order. a buy order must be at least .0000001 more than ask price, and a sell order must be .0000001 less than bid for an order to trigger. I guess as a work around for this bug you could add/sub to the default trade value to make it act more like a market order. Other wise I'm still loving it. Good job.

this is what I could see from stellarterm of a set of trades setup with lupoex:
https://stellar-public.slack.com/files/sacarlson/F689KQFJM/screenshot_at_2017-07-14_15-58-55.png
note the price is the same on both bid and ask at that time.

maybe you use Passive Offer when you setup trades? I'm not sure what else can cause this now.

istrau2

sacarlson That issue should be fixed now.

jed

Cool. Lot's of progress since I looked last.

Would be cool if it supported pathfinding when you send. (You send one currency and the person receives another)

When you create an offer that involves an asset you haven't trusted it spits: "There was an error in submitting the transaction to the stellar network. The transaction failed with the following code(s):
tx_failed, op_buy_no_trust,op_success" why not give you the option to trust the asset right there? Would also solve the other issue that it isn't very clear how to add trust otherwise.
I found the modify limit dialog. I'd rather it not ask me the limit. I think the common case is just to give the max limit. Probably don't need to give people the option.
I placed an order and it crossed but it was unclear to me that this had happened. I didn't realize the order was filled till I went back to my account page.

If there is a github repo for issues maybe add it at the footer of the site.

looking good!

jed

Would be cool if there were buy/sell links in your account balance view. or probably just a link "trade" next to each balance.

istrau2

@jed

1) Yes, one of my TODOs is to handle both errors and successes of various operations better (i.e. give the user more instructive feedback).
2) Hmmm, do you think a toggle trust on/off would be better (right in the bid/ask widget as well as on the balances page)?
3) by crossed do you mean that the trade occurred? If so, my next item (actually working on it now) is to add real-time function. I think that it will solve this.
4) Hmmm but in order to trade, the user needs to select a pair of assets (not just one). What about a "trade" link where a moda comes up and asks what they want to trade agains (prior to navigating to the exchange page)?

jed

2) I like the dialog because it explains a bit to people what is going on.

3) yeah "crossed" means that a trade occurred.

4) True. I guess I was assuming it would default to xlm vs whatever

istrau2

@jed Ok, so regarding 2) you think that there shouldn't be any option to set the limit? The modal should come up and explain what a trustline is and allow the user to toggle it on/off is that right?

istrau2

@sacarlson lupoex is now open source. The code can be seen at https://github.com/istrau2/lupoex-client

fiatjaf

The test version is failing with this._innerWindow(...).tradingViewApi is undefined when I try to load the XLM/BTC market.

Are markets (trading pairs) inserted manually by the LuPoEx team? In that case you should give some hint of who's the issuer of each asset that you list. Because you're not trading XLM for BTC or XLM for CNY actually, but IOUs of BTC emitted by someone etc., and that distinction is important. In the near future, when there are multiple issuers of assets with the same name that will become apparent, but is still important.

istrau2

@fiatjaf Thanks for the feedback.

Yes, we are aware that the test site is buggy. We are deploying a new version to it.

No, we do not add assets manually. All trading pairs are calculated in real time from the network.
That said, it seems you are referring to the "Top Ten" widget (that you would like to see the issuer of each asset in the pair). If that is the case, we have that on our to do list.

Look out for big changes to the lupoex interface!

istrau2

@fiatjaf I just pushed a fix to test.lupoex.com. Let me know if you experience any more issues.