C# SDK Contributions

kirbyrawr

Introduction

First of all i need to say that i didn't do this because of the SBC or for get any bounty, in fact i started making some pull requests before this SBC was announced.

1) Added Data object to the AccountResponse

Pull Request: https://github.com/elucidsoft/dotnet-stellar-sdk/pull/23

The Data object was missing from the AccountResponse and it prevented to use it in the SDK (https://www.stellar.org/developers/guides/concepts/list-of-operations.html#manage-data)

2) Documentation Improvements

Issue: https://github.com/elucidsoft/dotnet-stellar-sdk/issues/40
Pull Requests: https://github.com/elucidsoft/dotnet-stellar-sdk/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aclosed+author%3AKirbyrawr+docs

Basically the owner of the repo put an issue and i got interested since i wanted to learn how to do it so this is what i did.
1) Setup DocFX Generation tool properly for fix the github url links.
2) Forked a template and modified it for make it look better. (https://github.com/MathewSachin/docfx-tmpl)
3) Improved the generation of the documents by doing an assistant in shell script for easily management of the documentation and uploading with pull requests support.
4) Created specific branch for the documentation in the same project called gh-pages.

You can find the website here: https://elucidsoft.github.io/dotnet-stellar-sdk/api/index.html

Before
Before

After After

Assistant

3) SDK Examples

https://github.com/elucidsoft/dotnet-stellar-sdk/pull/58

Basically i started doing some examples (Will do more in the future) of how to use the SDK.
I created a new tab in the documentation website and i uploaded them there.
It's a first pass so it can contain some spelling errors and other issues.

Here is an example:
https://elucidsoft.github.io/dotnet-stellar-sdk/examples/send_native_assets.html

Send Native Assets

NON SUBMITTED BUT IMPORTANT CONTRIBUTIONS

Fixed bug when exporting a Transaction to XDR
#63
Port from Java SDK Transaction.FromXdr method.
#68
#71
New Examples

Conclusion

I hope i can keep doing contributions to this SDK since i like it and it helps me improve as well.
In fact i learned a lot by working with Stellar and i like it.

Cheers

elucidsoft

As the owner of this project I too would like to submit myself to SBC for contributions to the project. I am not sure if this is permitted, but I didn't see any guidance to the contrary. I spend ALOT of my time maintaining this project, merging pull requests, ensuring issues are resolved correctly, etc. I will outline the contributions outside of normal maintenance of the project below:

1) Added code coverages metrics to the project to track better code coverage. (https://github.com/elucidsoft/dotnet-stellar-sdk/pull/42)

2) Redid the way the Nuget package was setup so that developers can now target .NET Core and .NET Standard projects.

3) Added Friendbot support to the API

4) PathPaymentResponseMaxFix (https://github.com/elucidsoft/dotnet-stellar-sdk/pull/34)

5) Release 2.0 to re-align project for dotnetcore and dotnetstandard support. (https://github.com/elucidsoft/dotnet-stellar-sdk/commit/2469d647218010152f32c272288197edf2e8186c)

6) Created bip39 project as a seperate project for preperation of integrating mnemonic support into the sdk. (https://github.com/elucidsoft/dotnetstandard-bip39)

I also would like to mention I don't do this for any kind of reward. In fact I intentionally did not re-submit this project last SBC because I felt other members of the community deserved a chance. However, when I saw other SDK projects were rewarded I regretted not submitting the project. With that said, I will continue to support this project as I believe in Stellar and the community!

kirbyrawr

elucidsoft You did a lot of things and you are kind and strict (in terms of code and that's good!) with everyone who wants to contribute to the project, thanks for it.

Also i would like to add that he reply really fast to the issues (I know because i bothered him so many times with my things : ) ), give proper info and try to have a roadmap of the project, that's really valuable

brewaa

Hey Guys,

Fellow contributors. Haven't spoken to you all so nice to be acquainted. Keep up the good work on the c# SDK @elucidsoft !

I was working with your SDK recently for the server side of the project I'm building at the moment.

Good work. I can see the amount of time and effort it would take to get it that far. Please keep it going. That project needs your talent.

I ported a couple of StrKey helper methods from the JS SDK which you approved quickly. Thank you.

We really need to keep the SDK for C# going so anyone with some skills and some time to lend a hand please take a look at the GitHub repo and see if there's anything you can get your hands dirty with.

kirbyrawr

brewaa

I agree with you, this project needs to keep it up and @elucidsoft is doing great.
I'm barely learning how to contribute to a big project and also learning a lot of C# since i'm coming from a game background and that's not exactly the same even if it seems but this person is having patience with me checking the pull requests and clarifying things that are wrong, i appreciate that a lot.

Nice to meet you and thank you for the contributions too!

elucidsoft

kirbyrawr You are welcome, I've been doing this for over 20 years so anything I can do to help others get better. I'm still learning new things myself, it never stops. The community is one of the reasons I think Stellar will be #1, I haven't seen any other crypto with a developer community this strong and it's quite remarkable!!