Trezor integration progress update

zcc

I've implemented signing payment transactions on the Trezor and want to get feedback on the UI and check if anyone has features they'd like to see.

Unlike the Ledger, there's no "app store", so updates are a bit more involved on the Trezor and I want to make sure things work well before I submit the code to the Trezor team.

Please take a look at the screenshots below and let me know if you see any improvements or have any comments:

Simple payment transaction
This example sends 100 XLM to GBTVYY...

simple

The "WRN: TN" message at the bottom is a warning indicating that this is a testnet transaction. If this was submitted to the public network, no message would appear there.

Complex payment transaction
If a transaction gets more complex, additional data is displayed. For example, this next payment has:

A text memo
Time bounds (it's only valid between certain dates)
It's a payment for a custom asset with code TEST issued by GBTVY...

Note that the issuer is only partly shown. The screen that adds trust lines will show the full address, but at this point you've already trusted the asset so I don't think it's necessary to show the full address.

complex

umbrel

Great progress!

don't know maybe it's just me, but being able to see only part of the address gives me some disturbing sense of insecurity, even for my own account, I'd prefer more screens, but actually being able to verify everything.
Chances are not big but still pretty real, that 1 user gets multiple accounts with same prefix GDRXE, which will make their life miserable ?

How do you handle multiple operations?

zcc

umbrel The "index" (the 1 in "Signing with #1") will give you another way to verify you're using the expected account, but I think I could add the full address.

It takes 3 lines to fit an address, so I could change the first screen to be:

Fee: 0.00001 XLM (1 op)
Signing with:
GDRXE2BQUC3AZNPVFS
CEZ76NJ3WWL25FYFK6R
GZGIEKWE4SOOHSUJUJ6

And then move the memo to the next screen (or skip it if there's no memo).

For multiple operations, you'll see the total number of ops on the first screen and then you'll go through confirmation dialogs for each option. For example if there were two payments, it would look like:

Confirm overall transaction with 2 ops + fee + memo
Confirm first payment
Confirm second payment

umbrel

zcc The "index" (the 1 in "Signing with #1") will give you another way to verify you're using the expected account, but I think I could add the full address.

Yes, I know, but as I said this is something on emotional level (getting anxious that I can't see the full address), I can resolve these internal concerns when I think about it, but better if users never experience those doubts.

Great! Looking forward to test it on my trezor